[GitHub] [couchdb] jaydoane commented on a diff in pull request #4581: OTP 26 compatability

["jaydoane (via GitHub)" <gi...@apache.org>]

jaydoane commented on code in PR #4581:
URL: https://github.com/apache/couchdb/pull/4581#discussion_r1190180060


##########
src/couch_log/src/couch_log_trunc_io.erl:
##########
@@ -352,7 +352,7 @@ map_body(Map, Max, #print_options{depth = Depth}) when Max < 4; Depth =:= 0 ->
         _ -> {"...", 3}
     end;
 map_body(Map, Max, Options) ->
-    case maps:to_list(Map) of
+    case lists:sort(maps:to_list(Map)) of

Review Comment:
   This particular fix is for [these tests](https://github.com/apache/couchdb/blob/main/src/couch_log/src/couch_log_trunc_io.erl#L856-L956), which have not been recently changed.
   
   However, [this test](https://github.com/apache/couchdb/blob/main/src/couch_log/test/eunit/couch_log_formatter_test.erl#L35-L44) is recent and I agree it should be fixed. I've disabled it for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org