You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "sbmvirdi (via GitHub)" <gi...@apache.org> on 2023/08/01 19:49:27 UTC
[PR] [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced (eventmesh)
sbmvirdi opened a new pull request, #4316:
URL: https://github.com/apache/eventmesh/pull/4316
…ith lambda[HelloTask]
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4260 .
### Motivation
To contribute in open source
### Modifications
Updated: ChannelFutureListener to lambda expression as its a functional Interface
### Documentation
- Does this pull request introduce a new feature? No
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4316:
URL: https://github.com/apache/eventmesh/pull/4316#discussion_r1281306527
##########
.github/workflows/greetings.yml:
##########
@@ -26,7 +26,7 @@ jobs:
name: Greeting
runs-on: ubuntu-latest
steps:
- - uses: actions/first-interaction@v1
+ - uses: actions/first-interaction@v1.1.1
with:
Review Comment:
This modification shouldn't be part of this PR. The good thing is that this update won't affect the current workflow configuration. Acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4316:
URL: https://github.com/apache/eventmesh/pull/4316#issuecomment-1661690250
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4316](https://app.codecov.io/gh/apache/eventmesh/pull/4316?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (07adad3) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/dd40227299773c40d92ae86a484d5ec4f7df4980?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dd40227) will **decrease** coverage by `0.01%`.
> Report is 1 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head 07adad3 differs from pull request most recent head c05f0ed. Consider uploading reports for the commit c05f0ed to get more accurate results
```diff
@@ Coverage Diff @@
## master #4316 +/- ##
============================================
- Coverage 16.35% 16.35% -0.01%
- Complexity 1359 1360 +1
============================================
Files 594 594
Lines 25419 25414 -5
Branches 2394 2379 -15
============================================
- Hits 4158 4157 -1
+ Misses 20838 20836 -2
+ Partials 423 421 -2
```
| [Files Changed](https://app.codecov.io/gh/apache/eventmesh/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ntime/core/protocol/tcp/client/task/HelloTask.java](https://app.codecov.io/gh/apache/eventmesh/pull/4316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0hlbGxvVGFzay5qYXZh) | `0.00% <ø> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4316/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org