[jira] Resolved: (TUSCANY-3422) The travel sample "common" module in the "launchers" directory should be relocated

["Simon Nash (JIRA)" <de...@tuscany.apache.org>]

     [ https://issues.apache.org/jira/browse/TUSCANY-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Nash resolved TUSCANY-3422.
---------------------------------

    Resolution: Fixed
      Assignee: Simon Nash

Fixed under r898694 and r898695.  The changes are as proposed in the issue description,

> The travel sample "common" module in the "launchers" directory should be relocated
> ----------------------------------------------------------------------------------
>
>                 Key: TUSCANY-3422
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3422
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Travel Sample
>            Reporter: Simon Nash
>            Assignee: Simon Nash
>
> The travel sample has some common code for use by most of the launchers.  This code is currently located in the "common" subdirectory of the "launchers" directory.  This placement is confusing because it makes this common utility code look like another launcher, which it isn't.  This placement also means  that special code is needed in travelsample/distribution/src/main/components/bin-modules.xml to exclude this jar file from the launchers directory and place it in the lib directory instead.
> A cleaner structure would be to create a "util" directory in the source tree at the same level as "launchers" to hold utility code such as this.  The launcher common code would be placed in a "launcher-common" directory under "util".  The distribution tree would have a "util" directory containing launcher-common.jar, and the launcher jars in the distribution "launchers" directory would specify a dependency on ../util/launcher-common.jar in their Class-Path entries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.