You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/22 18:33:33 UTC
[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5126:
[WIP][Relay] XXXNode::make to constructor
ANSHUMAN87 opened a new pull request #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126
@tqchen, @jroesch
Sample change for #5069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5126:
[WIP][Relay] XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#discussion_r396138691
##########
File path: include/tvm/relay/expr.h
##########
@@ -284,18 +285,28 @@ class Let : public Expr {
class If;
/*! \brief container of If */
class IfNode : public ExprNode {
- public:
/*! \brief The condition */
- Expr cond;
+ Expr _cond;
Review comment:
Don't need this change to keep consistent to the used naming style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5126: [WIP][Relay]
XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#issuecomment-602270702
Thanks for taking the initiative. Given that the change could touch quite a few places. please also reply to the corresponding issue.
The particular change we intended is not to introduce member accessors and constructor in the Node class, but instead move the constructor from XXNode::make directly to the constructor of the reference class
Perhaps @zhiics can also followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5126:
[WIP][Relay] XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#issuecomment-602270702
Thanks for taking the initiative. Given that the change could touch quite a few places. please also reply to the corresponding issue so that the effort can be coordinated.
The particular change we intended is not to introduce member accessors and constructor in the Node class, but instead move the constructor from XXNode::make directly to the constructor of the reference class
Perhaps @zhiics can also followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5126: [WIP][Relay]
XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#issuecomment-602273871
Yeah, I can send a PR later if @ANSHUMAN87 doesn't mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics edited a comment on issue #5126:
[WIP][Relay] XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
zhiics edited a comment on issue #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#issuecomment-602273871
Yeah, I can send a PR later if @ANSHUMAN87 doesn't mind. I totally missed the original issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 closed pull request #5126: [WIP][Relay]
XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 closed pull request #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5126: [WIP][Relay]
XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#issuecomment-602253109
I have only made changes for IfNode, to get your valuable opinion. Once it is through, i can follow same template for others.
I had a dilemma of the format of constructor:
1:> If(IfNode(Args))
2:> If(Args) --> Ifnode(Args)
Currently implemented as per 1.
Eagerly waiting for your valuable feedback. TIA!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5126: [WIP][Relay]
XXXNode::make to constructor
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#issuecomment-602395895
Thanks @tqchen , @zhiics . Closing as zhiics has handled as part of PR(#5128)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services