[GitHub] [incubator-annotator] tilgovi commented on pull request #88: Restrict DOM scopes to be instances of Range

[GitBox <gi...@apache.org>]

tilgovi commented on pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88#issuecomment-689010515


   > I noticed that the ownerDocument(range) helper was not permitted by the eslint rule forbidding relative parent imports. Was that your reason to repeat the exact same lines in several files?
   
   No, that wasn't the reason. I felt that it was a couple lines of simple destructing and one nullish coalescing assignment. In context, it might often be useful to destructure other properties of the range at the same time. I'm fine to have a helper function, but it didn't feel necessary or very clarifying.
   
   I still do want to look at changing the lint rules, I'm sorry I have not had time to yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org