You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/29 05:50:00 UTC

[GitHub] [ignite] isapego commented on a change in pull request #9908: IGNITE-16745 fix the bug of SQLGetStmtAttr

isapego commented on a change in pull request #9908:
URL: https://github.com/apache/ignite/pull/9908#discussion_r837077572



##########
File path: modules/platforms/cpp/odbc-test/src/api_robustness_test.cpp
##########
@@ -795,6 +795,31 @@ BOOST_AUTO_TEST_CASE(TestSQLSetStmtAttr)
     SQLSetStmtAttr(stmt, SQL_ATTR_ROW_ARRAY_SIZE, 0, 0);
 }
 
+BOOST_AUTO_TEST_CASE(TestSQLSetStmtAttrGetStmtAttr)
+{
+    // check that statement array size is set correctly 
+
+    Connect("DRIVER={Apache Ignite};address=127.0.0.1:11110;schema=cache");
+
+    SQLCHAR buffer[ODBC_BUFFER_SIZE];
+    SQLINTEGER resLen = 0;
+
+    // repeat test for different values
+    SQLULEN valList[5] = {10, 52, 81, 103, 304};
+    for (SQLULEN val : valList) {

Review comment:
       Sorry, we do not use C++11 yet. Can you change this part to index form of for loop (`for (i = 0; ...)`)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org