You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Brian Femiano (JIRA)" <ji...@apache.org> on 2012/09/27 21:51:08 UTC
[jira] [Created] (GIRAPH-350) HBaseVertex i/o formats are not being
injected with Configuration via Configurable interface
Brian Femiano created GIRAPH-350:
------------------------------------
Summary: HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
Key: GIRAPH-350
URL: https://issues.apache.org/jira/browse/GIRAPH-350
Project: Giraph
Issue Type: Bug
Reporter: Brian Femiano
I reinstalled the latest giraph version from trunk.
When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465119#comment-13465119 ]
Brian Femiano commented on GIRAPH-350:
--------------------------------------
Attach patch was applied over a fresh checkout from SVN. Passes all checkstyle requirements as documented in GIRAPH-336.
This patch makes the following changes to giraph-formats-contrib:
-adds static setConf() methods to HBaseVertexInputFormat and HBaseVertexOutputFormat.
-removes Configurable interface from HBase and Accumulo formats.
-all review comments made in https://reviews.apache.org/r/7310/
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469439#comment-13469439 ]
Brian Femiano commented on GIRAPH-350:
--------------------------------------
No problem. They're mostly checkstyle fixes.
https://reviews.apache.org/r/7445/
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469020#comment-13469020 ]
Avery Ching commented on GIRAPH-350:
------------------------------------
[~nitay], could you take a look at this when you have a chance?
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470707#comment-13470707 ]
Nitay Joffe commented on GIRAPH-350:
------------------------------------
Ah sorry I looked over the review - it looks fine to me. As he said mostly harmless stuff around checkstyle fixes.
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470717#comment-13470717 ]
Hudson commented on GIRAPH-350:
-------------------------------
Integrated in Giraph-trunk-Commit #226 (See [https://builds.apache.org/job/Giraph-trunk-Commit/226/])
GIRAPH-350: HBaseVertex i/o formats are not being injected with
Configuration via Configurable interface. (bfem via aching) (Revision 1394835)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1394835
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph-formats-contrib/pom.xml
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexInputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/accumulo/AccumuloVertexOutputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hbase/HBaseVertexInputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hbase/HBaseVertexOutputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HCatalogVertexInputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HCatalogVertexOutputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/HiveGiraphRunner.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/format/hcatalog/package-info.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/TestHBaseRootMarkerVertextFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/edgemarker/TableEdgeInputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/format/hbase/edgemarker/TableEdgeOutputFormat.java
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469014#comment-13469014 ]
Brian Femiano commented on GIRAPH-350:
--------------------------------------
I would encourage this patch get reviewed since Nitay is making other concurrent, potentially conflicting modifactions.
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-350) HBaseVertex i/o formats are not being
injected with Configuration via Configurable interface
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Femiano updated GIRAPH-350:
---------------------------------
Attachment: GIRAPH-350.patch
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470704#comment-13470704 ]
Avery Ching commented on GIRAPH-350:
------------------------------------
+1, thanks for fixing this [~bfem]! Committing.
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-350) HBaseVertex i/o formats are not
being injected with Configuration via Configurable interface
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469213#comment-13469213 ]
Nitay Joffe commented on GIRAPH-350:
------------------------------------
Sure, [~bfem] can you post a reviewboard link with this diff?
> HBaseVertex i/o formats are not being injected with Configuration via Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not being called, and therefore the delegate 'tableInputFormat' is never being configured properly. The Accumulo i/o formats use static setters to avoid this requirement. That has the unfortunate side effect of having to remember to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on whether Configurable is an easy fix. I would imagine other input/output formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira