You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by julienledem <gi...@git.apache.org> on 2015/11/24 01:40:40 UTC
[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...
GitHub user julienledem opened a pull request:
https://github.com/apache/drill/pull/281
DRILL-4124: Make all uses of AutoCloseables use addSuppressed exceptions to avoid noise in logs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/julienledem/drill DRILL-4124
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/281.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #281
----
commit 0d18daee7b60caff56400736b75ebe9ff392e5b7
Author: Julien Le Dem <ju...@dremio.com>
Date: 2015-11-24T00:25:52Z
DRILL-4124: Make all uses of AutoCloseables use addSuppressed exceptions to avoid noise in logs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/281#issuecomment-159748623
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...
Posted by julienledem <gi...@git.apache.org>.
Github user julienledem commented on the pull request:
https://github.com/apache/drill/pull/281#issuecomment-160803787
Thanks for the heads up. I will fix this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/281#issuecomment-160799401
I put it on my merge branch but it actually caused two small compilation issues in other modules that were using the utility method you refactored. I forgot to update this with a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...
Posted by julienledem <gi...@git.apache.org>.
Github user julienledem commented on the pull request:
https://github.com/apache/drill/pull/281#issuecomment-160790637
Thanks @jaltekruse ! Did you mean to commit this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/281
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...
Posted by julienledem <gi...@git.apache.org>.
Github user julienledem commented on the pull request:
https://github.com/apache/drill/pull/281#issuecomment-161043400
@jaltekruse should be better now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---