You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "Havret (via GitHub)" <gi...@apache.org> on 2023/03/27 19:01:30 UTC
[GitHub] [activemq-nms-amqp] Havret opened a new pull request, #87: AMQNET-831 Add option to change ack mode via message properties
Havret opened a new pull request, #87:
URL: https://github.com/apache/activemq-nms-amqp/pull/87
This PR is a follow up to #86. It adds option to change AcknowledgementType via message properties. The implementation is based on qpid-jms. Additionally I reimplemented the message properties interceptor. The new implementation doesn't use reflection anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] Jefwillems commented on pull request #87: AMQNET-831 Add option to change ack mode via message properties
Posted by "Jefwillems (via GitHub)" <gi...@apache.org>.
Jefwillems commented on PR #87:
URL: https://github.com/apache/activemq-nms-amqp/pull/87#issuecomment-1522811260
Is there anything holding this PR back?
Also, a bit unrelated, but what's the release schedule once this and #86 are merged? Do you wait for other related packages to be updated? If so, i can try to contribute in those others as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] Havret commented on pull request #87: AMQNET-831 Add option to change ack mode via message properties
Posted by "Havret (via GitHub)" <gi...@apache.org>.
Havret commented on PR #87:
URL: https://github.com/apache/activemq-nms-amqp/pull/87#issuecomment-1523706277
Hi @Jefwillems I will try to cut a release over the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] Havret merged pull request #87: AMQNET-831 Add option to change ack mode via message properties
Posted by "Havret (via GitHub)" <gi...@apache.org>.
Havret merged PR #87:
URL: https://github.com/apache/activemq-nms-amqp/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org