You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/01/30 13:36:13 UTC

[GitHub] [incubator-linkis] dddyszy opened a new pull request #1359: #1257

dddyszy opened a new pull request #1359:
URL: https://github.com/apache/incubator-linkis/pull/1359


   fix the first upload of the resource failed
   see #1257 
   
   ### What is the purpose of the change
   (For example: EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
   The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection and session management.
   Related issues: #590. )
   
   ### Brief change log
   (for example:)
   - Define the core abstraction and interfaces of the EngineConn Factory;
   - Define the core abstraction and interfaces of Executor Manager.
   
   ### Verifying this change
   (Please pick either of the following options)  
   This change is a trivial rework / code cleanup without any test coverage.  
   (or)  
   This change is already covered by existing tests, such as (please describe tests).  
   (or)  
   This change added tests and can be verified as follows:  
   (example:)  
   - Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.
   
   ### Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): (yes / no)
   - Anything that affects deployment: (yes / no / don't know)
   - The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no)
   
   ### Documentation
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1359: fix the first upload of the resource failed #1257

Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1359:
URL: https://github.com/apache/incubator-linkis/pull/1359#discussion_r800342066



##########
File path: assembly-combined-package/assembly-combined/conf/linkis.properties
##########
@@ -33,6 +33,10 @@ wds.linkis.mysql.is.encrypt=false
 ##file path
 wds.linkis.filesystem.root.path=file:///tmp/linkis/
 wds.linkis.filesystem.hdfs.root.path=hdfs:///tmp/linkis/
+##bml path:default use hdfs
+wds.linkis.bml.is.hdfs=true
+wds.linkis.bml.hdfs.prefix=/apps-data
+wds.linkis.bml.local.prefix=/data/dss/bml

Review comment:
       Is it better to comment out the local path




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [incubator-linkis] dddyszy closed pull request #1359: fix the first upload of the resource failed #1257

Posted by GitBox <gi...@apache.org>.
dddyszy closed pull request #1359:
URL: https://github.com/apache/incubator-linkis/pull/1359


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org