You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/01/16 22:08:22 UTC
Review Request 69776: Fixed flakiness by adding per agent config dir
for mesos test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
Repository: mesos
Description
-------
In mesos tests, there are some cases that multiple agents are
running simultanuously. From commit 07bccc63, we start to have
agents share the same config dir in the test sandbox. Unit
tests that use the same credicial file dir may fail if there
are agents read and write to the same credential file
simultanuously. We should set unique dir per agent.
Diffs
-----
src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a
Diff: https://reviews.apache.org/r/69776/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 69776: Fixed flakiness by adding per agent config
dir for mesos test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/#review212091
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69775', '69776']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2795/mesos-review-69776
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2795/mesos-review-69776/logs/mesos-tests.log):
```
W0116 23:54:22.302806 2300 slave.cpp:3933] Ignoring shutdown framework 1d6ef6ec-3e6f-46a5-9d3d-504b081e86f0-0000 because it is terminating
I0116 23:54:22.304818 7028 master.cpp:1269] Agent 1d6ef6ec-3e6f-46a5-9d3d-504b081e86f0-S0 at slave(468)@192.10.1.6:54071 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0116 23:54:22.304818 7028 master.cpp:3272] Disconnecting agent 1d6ef6ec-3e6f-46a5-9d3d-504b081e86f0-S0 at slave(468)@192.10.1.6:54071 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0116 23:54:22.304818 7028 master.cpp:3291] Deactivating agent 1d6ef6ec-3e6f-46a5-9d3d-504b081e86f0-S0 at slave(468)@192.10.1.6:54071 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0116 23:54:22.305809 5112 hierarchical.cpp:358] Removed framework 1d6ef6ec-3e6f-46a5-9d3d-504b081e86f0-0000
I0116 23:54:22.305809 5112 hierarchical.cpp:802] Agent 1d6ef6ec-3e6f-46a5-9d3d-504b081e86f0-S0 deactivated
I0116 23:54:22.306818 2272 containerizer.cpp:2469] Destroying container 7749b365-f0d8-4154-a7e6-85a214a1a937 in RUNNING state
I0116 23:54:22.306818 2272 containerizer.cpp:3136] Transitioning the state of container 7749b365-f0d8-4154-a7e6-85a214a1a937 from RUNNING to DESTROYING
I0116 23:54:22.306818 2272 launcher.cpp:161] Asked to destroy container 7749b365-f0d8-4154-a7e6-85a214a1a937
W0116 23:54:22.307819 6756 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=3220 to peer '192.10.1.6:55894': IO failed with error code: The specified network name is no longer available.
W0116 23:54:22.309190 6756 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=1252 to peer '192.10.1.6:55895': IO failed with error code: The specified network name is no longer available.
I0116 23:54:22.356204 7028 containerizer.cpp:2975] Container 7749b365-f0d8-4154-a7e6-85a214a1a937 has exited
I0116 23:54:22.388252 5392 master.cpp:1109] Master terminating
I0116 23:54:22.389225 6924 h[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (690 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (707 ms total)
[----------] Global test environment tear-down
[==========] 1085 tests from 104 test cases ran. (505185 ms total)
[ PASSED ] 1084 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.OperationUpdatesUponAgentGone/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
ierarchical.cpp:644] Removed agent 1d6ef6ec-3e6f-46a5-9d3d-504b081e86f0-S0
I0116 23:54:22.684258 6756 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 16, 2019, 2:08 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69776/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 2:08 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In mesos tests, there are some cases that multiple agents are
> running simultanuously. From commit 07bccc63, we start to have
> agents share the same config dir in the test sandbox. Unit
> tests that use the same credicial file dir may fail if there
> are agents read and write to the same credential file
> simultanuously. We should set unique dir per agent.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a
>
>
> Diff: https://reviews.apache.org/r/69776/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 69776: Fixed flakiness by adding per agent config
dir for mesos test.
Posted by Gilbert Song <so...@gmail.com>.
> On Jan. 16, 2019, 2:10 p.m., Jie Yu wrote:
> > src/tests/mesos.cpp
> > Line 173 (original), 173 (patched)
> > <https://reviews.apache.org/r/69776/diff/1/?file=2120114#file2120114line173>
> >
> > s/agentDir/configDir/
I thought about `configDir`, sounds not appropriate to me, since store dir, fetcher dir are not config specific. While we are putting everything together, agentDir is the only name I can think of.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/#review212083
-----------------------------------------------------------
On Jan. 16, 2019, 2:08 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69776/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 2:08 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In mesos tests, there are some cases that multiple agents are
> running simultanuously. From commit 07bccc63, we start to have
> agents share the same config dir in the test sandbox. Unit
> tests that use the same credicial file dir may fail if there
> are agents read and write to the same credential file
> simultanuously. We should set unique dir per agent.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a
>
>
> Diff: https://reviews.apache.org/r/69776/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 69776: Fixed flakiness by adding per agent config
dir for mesos test.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 16, 2019, 10:10 p.m., Jie Yu wrote:
> > src/tests/mesos.cpp
> > Line 173 (original), 173 (patched)
> > <https://reviews.apache.org/r/69776/diff/1/?file=2120114#file2120114line173>
> >
> > s/agentDir/configDir/
>
> Gilbert Song wrote:
> I thought about `configDir`, sounds not appropriate to me, since store dir, fetcher dir are not config specific. While we are putting everything together, agentDir is the only name I can think of.
ok, sure!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/#review212083
-----------------------------------------------------------
On Jan. 16, 2019, 10:08 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69776/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 10:08 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In mesos tests, there are some cases that multiple agents are
> running simultanuously. From commit 07bccc63, we start to have
> agents share the same config dir in the test sandbox. Unit
> tests that use the same credicial file dir may fail if there
> are agents read and write to the same credential file
> simultanuously. We should set unique dir per agent.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a
>
>
> Diff: https://reviews.apache.org/r/69776/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 69776: Fixed flakiness by adding per agent config
dir for mesos test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/#review212083
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/mesos.cpp
Line 173 (original), 173 (patched)
<https://reviews.apache.org/r/69776/#comment297689>
s/agentDir/configDir/
- Jie Yu
On Jan. 16, 2019, 10:08 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69776/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 10:08 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In mesos tests, there are some cases that multiple agents are
> running simultanuously. From commit 07bccc63, we start to have
> agents share the same config dir in the test sandbox. Unit
> tests that use the same credicial file dir may fail if there
> are agents read and write to the same credential file
> simultanuously. We should set unique dir per agent.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a
>
>
> Diff: https://reviews.apache.org/r/69776/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 69776: Fixed flakiness by adding per agent config
dir for mesos test.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/#review212112
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On Jan. 16, 2019, 10:08 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69776/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 10:08 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In mesos tests, there are some cases that multiple agents are
> running simultanuously. From commit 07bccc63, we start to have
> agents share the same config dir in the test sandbox. Unit
> tests that use the same credicial file dir may fail if there
> are agents read and write to the same credential file
> simultanuously. We should set unique dir per agent.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a
>
>
> Diff: https://reviews.apache.org/r/69776/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 69776: Fixed flakiness by adding per agent config
dir for mesos test.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/
-----------------------------------------------------------
(Updated Jan. 22, 2019, 3 p.m.)
Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
Bugs: MESOS-9532
https://issues.apache.org/jira/browse/MESOS-9532
Repository: mesos
Description
-------
In mesos tests, there are some cases that multiple agents are
running simultanuously. From commit 07bccc63, we start to have
agents share the same config dir in the test sandbox. Unit
tests that use the same credicial file dir may fail if there
are agents read and write to the same credential file
simultanuously. We should set unique dir per agent.
Diffs
-----
src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a
Diff: https://reviews.apache.org/r/69776/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song