You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/27 17:34:05 UTC

[GitHub] [commons-lang] greatmastermario commented on pull request #924: LANG-1638: Added docs regarding week year support

greatmastermario commented on PR #924:
URL: https://github.com/apache/commons-lang/pull/924#issuecomment-1229233050

   > It looks OK to me, but the text could be improved, I think. Maybe add an example of what's an YYYY and an yyyy expected to match against?
   
   Thank you for the review. I have added a link tag to the Javadoc of GregorianCalendar which contains an explanation of week year. Hopefully that should work. I will add more if required.
   
   > Should the comment be at the class level instead of duplicated all over? A link to the class comment could also be used.
   
   Thank you for the suggestion. I agree, and I have moved all the method level docs up to the class level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org