You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/13 13:14:32 UTC
[GitHub] [apisix-helm-chart] CloudXiaobai opened a new pull request #114: 🔧 Add json schema to validate helm3 values.
CloudXiaobai opened a new pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114
Helm v3 added support to validate values in a chart's values.yaml file with JSON schemas.the json schema can also be provide a form for other webapp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #114: 🔧 Add json schema to validate helm3 values.
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114#discussion_r668767957
##########
File path: charts/apisix/values.schema.json
##########
@@ -0,0 +1,255 @@
+{
+ "$schema": "http://json-schema.org/schema#",
+ "type": "object",
+ "properties": {
+ "apisix": {
+ "type": "object",
+ "title": "APISIX Setting(s)",
+ "form": true,
+ "properties": {
+ "enabled": {
+ "type": "boolean",
+ "title": "Enable apisix",
+ "description": "Enable or disable Apache APISIX itself",
+ "form": true,
+ "default": true
+ },
+ "replicaCount": {
Review comment:
We should add the `minimum` constraint.
##########
File path: charts/apisix/values.schema.json
##########
@@ -0,0 +1,255 @@
+{
+ "$schema": "http://json-schema.org/schema#",
+ "type": "object",
+ "properties": {
+ "apisix": {
+ "type": "object",
+ "title": "APISIX Setting(s)",
Review comment:
```suggestion
"title": "Apache APISIX Setting(s)",
```
##########
File path: charts/apisix/values.schema.json
##########
@@ -0,0 +1,255 @@
+{
+ "$schema": "http://json-schema.org/schema#",
+ "type": "object",
+ "properties": {
+ "apisix": {
+ "type": "object",
+ "title": "APISIX Setting(s)",
+ "form": true,
+ "properties": {
+ "enabled": {
+ "type": "boolean",
+ "title": "Enable apisix",
+ "description": "Enable or disable Apache APISIX itself",
+ "form": true,
+ "default": true
+ },
+ "replicaCount": {
+ "type": "integer",
+ "title": "Number of replicas",
+ "form": true,
+ "default": 1,
+ "hidden": {
+ "condition": false,
+ "value": "apisix.enabled"
+ }
+ }
+ }
+ },
+ "etcd": {
+ "type": "object",
+ "title": "Etcd configuration",
+ "form": true,
+ "properties": {
+ "enabled": {
+ "type": "boolean",
+ "title": "Enable etcd",
+ "description": "install etcd(v3) by default, set false if do not want to install etcd(v3) together",
+ "form": true,
+ "default": true
+ },
+ "replicaCount": {
Review comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] CloudXiaobai commented on pull request #114: chore: 🔧 Add json schema to validate helm3 values.
Posted by GitBox <gi...@apache.org>.
CloudXiaobai commented on pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879217739
> @CloudXiaobai It seems that this schema is not complete.
Yes, I think it is sufficient to check only the core parts, most users will not bother to configure the full value file.
Of course, if necessary, we can completed the values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #114: chore: 🔧 Add json schema to validate helm3 values.
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879618865
> > @CloudXiaobai It seems that this schema is not complete.
>
> Yes, I think it is sufficient to check only the core parts, most users will not bother to configure the full value file.
> Of course, if necessary, we can completed the values
I know it would be tedious to give a complete description, but we should try to cover all of them. We may split this task into several PRs, in each PR, we can cover a section there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #114: chore: 🔧 Add json schema to validate helm3 values.
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879618042
> Yes, I think it is sufficient to check only the core parts, most users will not bother to configure the full value file.
We may use some tools to help us to generate such a jsonschema file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #114: chore: 🔧 Add json schema to validate helm3 values.
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879093330
@CloudXiaobai It seems that this schema is not complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers removed a comment on pull request #114: chore: 🔧 Add json schema to validate helm3 values.
Posted by GitBox <gi...@apache.org>.
tokers removed a comment on pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879618042
> Yes, I think it is sufficient to check only the core parts, most users will not bother to configure the full value file.
We may use some tools to help us to generate such a jsonschema file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org