You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@distributedlog.apache.org by khurrumnasimm <gi...@git.apache.org> on 2017/01/06 09:48:07 UTC
[GitHub] incubator-distributedlog pull request #106: DL-179: Support ZStandard Compre...
GitHub user khurrumnasimm opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/106
DL-179: Support ZStandard Compression
This PR is to add [Zstd](https://github.com/facebook/zstd) compression support.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khurrumnasimm/incubator-distributedlog kn/zstd
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 618cf56552e3bcb6660eb42307f0f1285f7b060a
Author: Khurrum Nasim <kh...@gmail.com>
Date: 2017-01-06T09:42:38Z
DL-179: Support ZStandard Compression
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #106: DL-179: Support ZStandard Compression
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/106
@khurrumnasimm do you have any benchmark results to show performance? it seems we have only 2 bits to tolerant compression algorithm to the record/entry format. I'd like to confirm if the result is promising enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog pull request #106: DL-179: Support ZStandard Compre...
Posted by leighst <gi...@git.apache.org>.
Github user leighst commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/106#discussion_r98694134
--- Diff: distributedlog-protocol/src/main/java/org/apache/distributedlog/io/ZstdCompressionCodec.java ---
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.distributedlog.io;
+
+import com.github.luben.zstd.Zstd;
+import com.google.common.base.Stopwatch;
+import java.util.Arrays;
+import java.util.concurrent.TimeUnit;
+import org.apache.bookkeeper.stats.OpStatsLogger;
+
+/**
+ * ZStandard Compression Codec.
+ *
+ * {@link http://facebook.github.io/zstd/}
+ */
+public class ZstdCompressionCodec implements CompressionCodec {
+
+ public ZstdCompressionCodec() {}
+
+ byte[] getOrCopyData(byte[] data, int offset, int length) {
+ byte[] copyOfData;
+ if (0 == offset && length == data.length) {
+ copyOfData = data;
+ } else {
+ copyOfData = Arrays.copyOfRange(data, offset, offset + length);
+ }
+ return copyOfData;
+ }
+
+ @Override
+ public byte[] compress(byte[] data, int offset, int length, OpStatsLogger compressionStat) {
+ Stopwatch watch = Stopwatch.createStarted();
+ // TODO: make the compression level configurable.
+ byte[] compressed = Zstd.compress(getOrCopyData(data, offset, length), 3);
+
+ compressionStat.registerSuccessfulEvent(watch.elapsed(TimeUnit.MICROSECONDS));
+ return compressed;
+ }
+
+ @Override
+ public byte[] decompress(byte[] data, int offset, int length, OpStatsLogger decompressionStat) {
+ Stopwatch watch = Stopwatch.createStarted();
+ byte[] compressedData = getOrCopyData(data, offset, length);
+ int decompressedSize = (int) Zstd.decompressedSize(compressedData);
+ byte[] decompressedData = new byte[decompressedSize];
+ // TODO: make the compression level configurable.
--- End diff --
per DL-128, can we try to either tag such TODOs with jira tickets (or just avoid them if not necessary)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---