You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "stevenzwu (via GitHub)" <gi...@apache.org> on 2023/06/28 13:49:01 UTC
[GitHub] [iceberg] stevenzwu opened a new pull request, #7936: Core: add missing start and length for FileScanTaskParser.
stevenzwu opened a new pull request, #7936:
URL: https://github.com/apache/iceberg/pull/7936
Also added `schema()` override for BaseFileScanTask$SplitScanTask inner class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #7936: Core: add missing start and length for FileScanTaskParser.
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on PR #7936:
URL: https://github.com/apache/iceberg/pull/7936#issuecomment-1626853283
issue #1698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7936: Core: add missing start and length for FileScanTaskParser.
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7936:
URL: https://github.com/apache/iceberg/pull/7936#discussion_r1245377049
##########
core/src/main/java/org/apache/iceberg/FileScanTaskParser.java:
##########
@@ -33,6 +33,8 @@ public class FileScanTaskParser {
private static final String SCHEMA = "schema";
private static final String SPEC = "spec";
private static final String DATA_FILE = "data-file";
+ private static final String START = "start";
Review Comment:
nit: do we want to call this `offset` to align with how the field is named in `SplitScanTask`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #7936: Core: add missing start and length for FileScanTaskParser.
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on PR #7936:
URL: https://github.com/apache/iceberg/pull/7936#issuecomment-1611453549
Will create a separate PR for switching serialization of Flink IcebergSourceSplit to the JSON parsers in a separate PR. here is the commit in my personal fork that shows the Flink part of the change. https://github.com/stevenzwu/iceberg/commit/edc94d3082e3b34ba4c40e61f926deb4f13f2324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu merged pull request #7936: Core: add missing start and length for FileScanTaskParser.
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu merged PR #7936:
URL: https://github.com/apache/iceberg/pull/7936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #7936: Core: add missing start and length for FileScanTaskParser.
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on PR #7936:
URL: https://github.com/apache/iceberg/pull/7936#issuecomment-1618573406
thanks @nastra @Fokko @RussellSpitzer for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #7936: Core: add missing start and length for FileScanTaskParser.
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on code in PR #7936:
URL: https://github.com/apache/iceberg/pull/7936#discussion_r1245910051
##########
core/src/main/java/org/apache/iceberg/FileScanTaskParser.java:
##########
@@ -33,6 +33,8 @@ public class FileScanTaskParser {
private static final String SCHEMA = "schema";
private static final String SPEC = "spec";
private static final String DATA_FILE = "data-file";
+ private static final String START = "start";
Review Comment:
I call it `start` to match the `FileScanTask/ContentScantask` method name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org