You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "DanielLeens (via GitHub)" <gi...@apache.org> on 2026/06/01 10:41:15 UTC
Re: [PR] [SEATUNNEL-10685] prevent timestamp_ntz from being saved as timestamp_ltz [seatunnel]
DanielLeens commented on PR #10724:
URL: https://github.com/apache/seatunnel/pull/10724#issuecomment-4591810328
Thanks for the follow-up. I checked the current PR state before replying, and the head is still `9a4e6f1fa5f1be26e2818920b1c724e1333d248a`, which is the same revision Daniel already reviewed on May 21.
So from Daniel's side this is still a reply-only follow-up rather than a new full re-review on a changed head. The current blocker remains the same one from the latest Daniel review: `TextSerializationSchema` still drops the `TIMESTAMP_TZ` offset on the normal text-output path by converting `OffsetDateTime` to `LocalDateTime`.
Once there is a new commit that preserves the offset on that text serialization path (or fails explicitly instead of silently degrading it), I will re-review the latest head again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org