[GitHub] mrmcduff opened a new pull request #6772: creating new circular-json safe stringify and replacing one call

[GitBox <gi...@apache.org>]

mrmcduff opened a new pull request #6772: creating new circular-json safe stringify and replacing one call
URL: https://github.com/apache/incubator-superset/pull/6772
 
 
   Fixes one instance of https://github.com/apache/incubator-superset/issues/6761
   
   Why not replace every call to JSON.stringify in this PR?
   - If there is an unknown bug in the source, this limits the exposure (and no other crashes have yet been reported)
   - A follow-up PR should eliminate all unprotected references to JSON.stringify
   
   Creating a time-series table using sample data without the PR:
   <img width="518" alt="screen shot 2019-01-25 at 3 51 01 pm" src="https://user-images.githubusercontent.com/19434213/51861134-4bc1d380-22f0-11e9-9fb6-6188dd911955.png">
   
   Creating a time-series table using sample data with this PR:
   <img width="873" alt="screen shot 2019-01-28 at 11 17 31 am" src="https://user-images.githubusercontent.com/19434213/51861150-52e8e180-22f0-11e9-9066-e120a9820925.png">
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org