You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/01/14 22:45:49 UTC
[GitHub] mike-jumper commented on a change in pull request #353:
GUACAMOLE-577: Support for configuring the Guacamole Proxy in LDAP
Connections
mike-jumper commented on a change in pull request #353: GUACAMOLE-577: Support for configuring the Guacamole Proxy in LDAP Connections
URL: https://github.com/apache/guacamole-client/pull/353#discussion_r247688814
##########
File path: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
##########
@@ -167,18 +201,34 @@
// Parse name
String name = parameter.substring(0, equals);
String value = parameter.substring(equals+1);
-
- config.setParameter(name, value);
+
+ // Pull out and set proxy parameters, if present
+ // Otherwise set the parameter.
+ switch(name) {
+ case PROXY_HOST_PARAMETER:
Review comment:
Alrighty - we now have confirmation from the Apache Directory folks: https://lists.apache.org/thread.html/1897a20401348da14c4b20483464ee8ee06ffb510a29fa86d475d200@%3Cdev.directory.apache.org%3E
We can proceed with `1.3.6.1.4.1.18060.18`, and they will be updating the Apache Directory website to list the various reserved ASF OID branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services