You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Master-Frank (via GitHub)" <gi...@apache.org> on 2026/10/11 16:58:43 UTC
[PR] fix(ui): allow submitting the New project dialog without a name [maka]
Master-Frank opened a new pull request, #6073:
URL: https://github.com/apache/maka/pull/6073
Fixes #6047
## What
The New project dialog no longer requires a name before the folder picker opens. Submit is always enabled; an empty field submits as "no name", and the caller uses the folder's basename (the catalog's existing fallback in `projects.add`).
## Changes
- `NewProjectDialog`: `onSubmit(name?: string)`; empty/whitespace input submits `undefined`; submit button no longer disabled while empty; doc comment updated.
- `WorkspacePickerGroup.onAdd?(name?: string)` and its callers (task-entry controller, session-workspace recovery, Settings projects page) propagate the optional name; Settings passes `undefined` to `window.maka.projects.add` when blank so the service-side basename fallback applies.
- Copy (en / zh-CN / zh-TW): description now reads as an optional override of the folder name; name label marked optional.
- Tests: dialog empty-name and trimmed-name cases; Settings blank-name submission asserts `add` receives `undefined`.
## Verification
- `npm --workspace @maka/ui run build && npm --workspace @maka/ui run test:dist` — 735/735 pass
- `npm --workspace @maka/desktop run build:test` — success
- `project-add-restore`, `task-entry-controller`, `task-entry-provider-scope` — 80/80 pass
- `biome lint` on changed files — clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): allow submitting the New project dialog without a name [maka]
Posted by "Master-Frank (via GitHub)" <gi...@apache.org>.
Master-Frank commented on PR #6073:
URL: https://github.com/apache/maka/pull/6073#issuecomment-6111562884
> Thanks for re-creating this. Before we review it: the AI-use section says generative tooling made a substantive contribution, but doesn't say which tool, and the commit has no `Generated-by:` trailer. Given #6059/#6060, could you name the tool used for this version (in the PR description, and ideally as a `Generated-by:` trailer)? As noted there, the project currently cannot accept Grok-generated changes; any other tool is fine. We'll review as soon as that's in place.
>
> > **Automated notice:** This comment was posted by an automated agent operated by Astro-Han, at the maintainer's direction.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): allow submitting the New project dialog without a name [maka]
Posted by "Master-Frank (via GitHub)" <gi...@apache.org>.
Master-Frank commented on PR #6073:
URL: https://github.com/apache/maka/pull/6073#issuecomment-6116316237
> > **Automated review notice:** This comment was posted by an automated review agent. It is not an independent human review and does not replace one.
>
> I found no P0–P2 issue at `3d598c8eadeca716b5b3aaea5c80261e19f327e3`.
>
> The change removes the dialog's empty-name submission gate, trims an entered name, and passes `undefined` when blank. I traced that optional value through the workspace picker, Task Entry header, session-workspace recovery and Settings callers. The local management service already skips renaming when no name is supplied; the directory-backed catalog supplies its existing default name. Remote directory handoff retains its existing no-override behavior. The en/zh-CN/zh-TW labels and descriptions consistently identify the name as optional, matching the behavior proposed in #6047 without changing the directory-backed project model.
>
> After a fresh dependency install and the normal root test build, all 735 UI tests, all 90 tests across the affected Desktop controller/provider/registration and project-service files, and all four Desktop typechecks passed. All ten changed files pass Biome. A mounted-dialog probe connected the actual component to the real management service and persisted catalog: blank, whitespace-only and trimmed custom names worked in all three locales; cancelling the directory callback created no project. Restoring the old non-empty-name guard makes the blank-name regression fail; restoring this head passes all three dialog tests.
>
> **P3 — commit attribution:** the PR body declares substantive OpenCode use, but commit `3d598c8e` has no `Generated-by:` trailer. Please add the declared tool to the commit message and retain the attribution through squash.
>
> The exact head's [CI](https://github.com/apache/maka/actions/runs/38157696712) is successful and it merges cleanly with checked main `6b9457f5`. No protocol, epoch or database schema changed. I did not run the full monorepo test suite or a native Electron folder picker; the composed probe uses a controlled directory callback. This comment is not a merge approval.
Thanks for the review. Added the `Generated-by: OpenCode` trailer to the commit and force-pushed (`8d9be01e`), so the attribution will be retained through squash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): allow submitting the New project dialog without a name [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #6073:
URL: https://github.com/apache/maka/pull/6073#issuecomment-6111521583
Thanks for re-creating this. Before we review it: the AI-use section says generative tooling made a substantive contribution, but doesn't say which tool, and the commit has no `Generated-by:` trailer. Given #6059/#6060, could you name the tool used for this version (in the PR description, and ideally as a `Generated-by:` trailer)? As noted there, the project currently cannot accept Grok-generated changes; any other tool is fine. We'll review as soon as that's in place.
> **Automated notice:** This comment was posted by an automated agent operated by Astro-Han, at the maintainer's direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): allow submitting the New project dialog without a name [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #6073:
URL: https://github.com/apache/maka/pull/6073#issuecomment-6135532150
Thanks for the contribution! Merging now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): allow submitting the New project dialog without a name [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6073:
URL: https://github.com/apache/maka/pull/6073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org