[GitHub] [pinot] kbastani commented on a change in pull request #8024: Created EmptyQuickstart command

[GitBox <gi...@apache.org>]

kbastani commented on a change in pull request #8024:
URL: https://github.com/apache/pinot/pull/8024#discussion_r785175337



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
##########
@@ -93,9 +95,31 @@ public QuickstartRunner(List<QuickstartTableRequest> tableRequests, int numContr
     _enableTenantIsolation = enableIsolation;
     _authToken = authToken;
     _configOverrides = configOverrides;
+    _zkAddress = null;
+    _deleteExistingData = true;

Review comment:
       I've refactored the constructor to make this simpler. For deleting existing data, if the flag is set to `false` for any of the other quickstart commands, there will be an exception on startup when attempting to create a data directory that already exists. I've added `_deleteExistingData` as a constructor argument for future quickstart commands.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org