You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/27 02:49:28 UTC

[GitHub] [superset] ktmud commented on a change in pull request #12742: fix: Prevent dashboard with filter_values template cause incompatible indicator

ktmud commented on a change in pull request #12742:
URL: https://github.com/apache/superset/pull/12742#discussion_r564987551



##########
File path: superset/viz.py
##########
@@ -102,6 +103,8 @@
     "size",
 ]
 
+FILTER_VALUES_REGEX = re.compile(r"FILTER_VALUES\(['\"](\w+)['\"]\,", re.IGNORECASE)

Review comment:
       I think Jinja context variables/functions are case sensitive. Running `SELECT {{ FILTER_VALUES('region') }};` in SQL Lab gives me `undefined` errors.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org