You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/16 23:52:23 UTC
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5812: Bring Your Own Datatypes
tqchen commented on a change in pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r489815454
##########
File path: .gitmodules
##########
@@ -10,3 +10,6 @@
[submodule "3rdparty/vta-hw"]
path = 3rdparty/vta-hw
url = https://github.com/apache/incubator-tvm-vta
+[submodule "3rdparty/universal"]
+ path = 3rdparty/universal
Review comment:
I took a look at the current repo. Given that the repo contains binaries(exe and pdf) we cannot make it as a submodule (due to the requirement that all released code need to be sourc).
We can give users instructions to go and download the library though. It would still be nice to have the example built on top of the bfloat16 toy examples.
##########
File path: 3rdparty/bfloat16/bfloat16.cc
##########
@@ -1,84 +0,0 @@
-/*
- Copyright (c) 2019 by Contributors
- \file tvm/src/codegen/custom_datatypes/mybfloat16.cc
Review comment:
It would still be great to have a library independent examples
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org