[GitHub] [airflow] o-nikolas commented on a diff in pull request #26652: Add GlacierUploadArchiveOperator

[GitBox <gi...@apache.org>]

o-nikolas commented on code in PR #26652:
URL: https://github.com/apache/airflow/pull/26652#discussion_r999903465


##########
airflow/providers/amazon/aws/operators/glacier.py:
##########
@@ -54,3 +54,55 @@ def __init__(
     def execute(self, context: Context):
         hook = GlacierHook(aws_conn_id=self.aws_conn_id)
         return hook.retrieve_inventory(vault_name=self.vault_name)
+
+
+class GlacierUploadArchiveOperator(BaseOperator):
+    """
+    This operation adds an archive to a vault
+
+    .. seealso::
+        For more information on how to use this operator, take a look at the guide:
+        :ref:`howto/operator:GlacierUploadArchiveOperator`
+
+    :param account_id: The AWS account ID of the account that owns the vault.
+        You can either specify an AWS account ID or optionally a single `-` (hyphen),
+        in which case Amazon S3 Glacier uses the AWS account ID associated with
+        the credentials used to sign the request
+    :param vault_name: The name of the vault
+    :param archive: A bytes or seekable file-like object. The data to upload.
+    :param description: The description of the archive you are uploading

Review Comment:
   Yeah, so far we've tried to stick to boto names (but _not_ the camel case they use). But I'd say it's more of a best practice than a hard rule (though we should start codifying these unwritten rules and best practices for the Amazon provider package in an RST file, we've had this in the back of our mind for a while now).
   In this case if you think the boto names are wildly misleading, I'd be happy to approve that. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org