You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/24 18:59:04 UTC
[GitHub] [incubator-yunikorn-scheduler-interface] chia7712 opened a new pull request #50: [YUNIKORN-826] the makefile in scheduler-interface module should not …
chia7712 opened a new pull request #50:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/50
…use bash-builtin "[["
### What is this PR for?
As other modules (core and k8shim) don't use such bash syntax, it would be better to make them consistent. Also, that can't work in sh shell.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-826
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s closed pull request #50: [YUNIKORN-826] the makefile in scheduler-interface module should not …
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #50:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org