[GitHub] [arrow] mrkn commented on pull request #7114: ARROW-7297: [C++] Add value accessor in sparse tensor class

[GitBox <gi...@apache.org>]

mrkn commented on pull request #7114:
URL: https://github.com/apache/arrow/pull/7114#issuecomment-625251725


   I'm the original reporter of the JIRA ticket, but I don't know whether or not there are actual use cases of random access to values in sparse tensors.  The JIRA ticket came from the existence of value accessing features in scipy's sparse tensors.
   
   I guess my mistake is making the ticket priority Major.  It should be Minor at the creation time.
   
   I think the feature mentioned in the JIRA ticket presumably can be a different way from providing `SparseTensor::Value<T>` function.  IMO, the functionality can be decomposed the following sub-features, and providing them can be alternative to only `SparseTensor::Value<T>`.
   
   - Iterating existing indices in a SparseIndex
   - Finding the given index in a SparseIndex and returning the offset of the index
   - Returning the value of the given offset
   - Making the slice of a SparseTensor
   
   By the way, this implementation proposal is not acceptable even if there are any realistic use cases of `SparseTensor::Value<T>`.  `CalculateValueOffset` function should be implemented in each subclass of SparseIndex class.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org