[GitHub] [solr] NazerkeBS commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

[GitBox <gi...@apache.org>]

NazerkeBS commented on a change in pull request #322:
URL: https://github.com/apache/solr/pull/322#discussion_r719176537



##########
File path: solr/core/src/java/org/apache/solr/core/ZkContainer.java
##########
@@ -144,25 +139,6 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) {
           } else {
             UrlScheme.INSTANCE.setUrlScheme(System.getProperty(URL_SCHEME, HTTP));
           }
-
-          if (zkServer.getServers().size() > 1 && confDir == null && boostrapConf == false) {
-            // we are part of an ensemble and we are not uploading the config - pause to give the config time
-            // to get up
-            Thread.sleep(10000);

Review comment:
       hi @markrmiller, I encountered this logic, while moving these `bootstrap_confdir ` and `bootstrap_conf` properties to ConfigSetService. It seems to me this logic is no longer valid and removed it.  Could you elaborate more on this logic if it is needed? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org