You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/25 10:21:16 UTC
[GitHub] [dubbo-go-pixiu] mark4z opened a new pull request #228: remove plugins
mark4z opened a new pull request #228:
URL: https://github.com/apache/dubbo-go-pixiu/pull/228
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Remove plugins because it's not production ready
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #228: remove plugins
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #228:
URL: https://github.com/apache/dubbo-go-pixiu/pull/228#issuecomment-886179647
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#228](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3eda7d3) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/19f00a6225862797e6c2141bafec1a7de7d30827?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f00a6) will **increase** coverage by `0.83%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3eda7d3 differs from pull request most recent head 3588b18. Consider uploading reports for the commit 3588b18 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
+ Coverage 39.71% 40.55% +0.83%
===========================================
Files 40 39 -1
Lines 2397 2266 -131
===========================================
- Hits 952 919 -33
+ Misses 1343 1255 -88
+ Partials 102 92 -10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `2.78% <ø> (+0.31%)` | :arrow_up: |
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.18% <ø> (+0.54%)` | :arrow_up: |
| [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `43.07% <ø> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19f00a6...3588b18](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #228: remove plugins
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #228:
URL: https://github.com/apache/dubbo-go-pixiu/pull/228#issuecomment-886179647
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#228](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3588b18) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/19f00a6225862797e6c2141bafec1a7de7d30827?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f00a6) will **increase** coverage by `0.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
+ Coverage 39.71% 40.55% +0.83%
===========================================
Files 40 39 -1
Lines 2397 2266 -131
===========================================
- Hits 952 919 -33
+ Misses 1343 1255 -88
+ Partials 102 92 -10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `2.78% <ø> (+0.31%)` | :arrow_up: |
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.18% <ø> (+0.54%)` | :arrow_up: |
| [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `43.07% <ø> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19f00a6...3588b18](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #228: remove plugins
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #228:
URL: https://github.com/apache/dubbo-go-pixiu/pull/228#issuecomment-886179647
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#228](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e87f2fe) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1c60c3c6dae39821dfe85d4acd9f8a7360879421?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c60c3c) will **increase** coverage by `0.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
+ Coverage 39.71% 40.55% +0.83%
===========================================
Files 40 39 -1
Lines 2397 2266 -131
===========================================
- Hits 952 919 -33
+ Misses 1343 1255 -88
+ Partials 102 92 -10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `2.78% <ø> (+0.31%)` | :arrow_up: |
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.18% <ø> (+0.54%)` | :arrow_up: |
| [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `43.07% <ø> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1c60c3c...e87f2fe](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #228: remove plugins
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #228:
URL: https://github.com/apache/dubbo-go-pixiu/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #228: remove plugins
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #228:
URL: https://github.com/apache/dubbo-go-pixiu/pull/228#issuecomment-886179647
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#228](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e87f2fe) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1c60c3c6dae39821dfe85d4acd9f8a7360879421?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c60c3c) will **increase** coverage by `0.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
+ Coverage 39.71% 40.55% +0.83%
===========================================
Files 40 39 -1
Lines 2397 2266 -131
===========================================
- Hits 952 919 -33
+ Misses 1343 1255 -88
+ Partials 102 92 -10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `2.78% <ø> (+0.31%)` | :arrow_up: |
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `20.18% <ø> (+0.54%)` | :arrow_up: |
| [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `43.07% <ø> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1c60c3c...e87f2fe](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org