You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/04/15 08:36:29 UTC
[PR] Updating docs to reflect latest state of project for AF3 [airflow]
amoghrajesh opened a new pull request, #49280:
URL: https://github.com/apache/airflow/pull/49280
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
From an initial skim through the docs
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044061024
##########
airflow-core/docs/security/secrets/secrets-backend/index.rst:
##########
@@ -75,6 +78,32 @@ the example below.
$ airflow config get-value secrets backend
airflow.providers.google.cloud.secrets.secret_manager.CloudSecretManagerBackend
+Worker Specific Configuration
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The above section covers a general configuration option for all Airflow nodes. But with Airflow 3, if you want to
+configure separate secrets backend for workers, you can do that using:
Review Comment:
```suggestion
The above section covers a general configuration option for all Airflow components. But with Airflow 3, if you want to
configure separate secrets backend for workers, you can do that using:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044075191
##########
airflow-core/docs/core-concepts/sensors.rst:
##########
@@ -27,6 +27,6 @@ Because they are primarily idle, Sensors have two different modes of running so
The ``poke`` and ``reschedule`` modes can be configured directly when you instantiate the sensor; generally, the trade-off between them is latency. Something that is checking every second should be in ``poke`` mode, while something that is checking every minute should be in ``reschedule`` mode.
-Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
+Much like Operators, Airflow has a large set of pre-built Sensors(housed in the standard provider) you can use, both in core Airflow(present in standard provider) as well as via our *providers* system.
Review Comment:
maybe better to explicitly state that they are now present in "standard provider". Your call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044646340
##########
airflow-core/docs/core-concepts/sensors.rst:
##########
@@ -27,6 +27,6 @@ Because they are primarily idle, Sensors have two different modes of running so
The ``poke`` and ``reschedule`` modes can be configured directly when you instantiate the sensor; generally, the trade-off between them is latency. Something that is checking every second should be in ``poke`` mode, while something that is checking every minute should be in ``reschedule`` mode.
-Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
+Much like Operators, Airflow has a large set of pre-built Sensors(housed in the standard provider) you can use, both in core Airflow(present in standard provider) as well as via our *providers* system.
Review Comment:
*providers* takes care of Standard or other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044055553
##########
airflow-core/docs/core-concepts/sensors.rst:
##########
@@ -27,6 +27,6 @@ Because they are primarily idle, Sensors have two different modes of running so
The ``poke`` and ``reschedule`` modes can be configured directly when you instantiate the sensor; generally, the trade-off between them is latency. Something that is checking every second should be in ``poke`` mode, while something that is checking every minute should be in ``reschedule`` mode.
-Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
+Much like Operators, Airflow has a large set of pre-built Sensors(housed in the standard provider) you can use, both in core Airflow(present in standard provider) as well as via our *providers* system.
Review Comment:
"providers" will also include standard provider. Why to again specifically mention about standard provider in brackets?
```suggestion
Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044645385
##########
airflow-core/docs/core-concepts/sensors.rst:
##########
@@ -27,6 +27,6 @@ Because they are primarily idle, Sensors have two different modes of running so
The ``poke`` and ``reschedule`` modes can be configured directly when you instantiate the sensor; generally, the trade-off between them is latency. Something that is checking every second should be in ``poke`` mode, while something that is checking every minute should be in ``reschedule`` mode.
-Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
+Much like Operators, Airflow has a large set of pre-built Sensors(housed in the standard provider) you can use, both in core Airflow(present in standard provider) as well as via our *providers* system.
Review Comment:
```suggestion
Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #49280:
URL: https://github.com/apache/airflow/pull/49280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044059717
##########
airflow-core/docs/core-concepts/sensors.rst:
##########
@@ -27,6 +27,6 @@ Because they are primarily idle, Sensors have two different modes of running so
The ``poke`` and ``reschedule`` modes can be configured directly when you instantiate the sensor; generally, the trade-off between them is latency. Something that is checking every second should be in ``poke`` mode, while something that is checking every minute should be in ``reschedule`` mode.
-Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
+Much like Operators, Airflow has a large set of pre-built Sensors(housed in the standard provider) you can use, both in core Airflow(present in standard provider) as well as via our *providers* system.
Review Comment:
The reason i do that is because as far as new users are concerned, standard provider is as good as core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044110414
##########
airflow-core/docs/security/secrets/secrets-backend/index.rst:
##########
@@ -43,6 +43,9 @@ then metastore. This search ordering is not configurable. Though, in some alter
the option to filter which connection/variable/config is searched in the secret backend. Please look at the
documentation of the secret backend you are using to see if such option is available.
+On the other hand, if a workers secrets backend is defined, the order of lookup has higher priority for the workers secrets
+backend and than the secrets backend.
Review Comment:
Ah yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044059515
##########
airflow-core/docs/security/secrets/secrets-backend/index.rst:
##########
@@ -43,6 +43,9 @@ then metastore. This search ordering is not configurable. Though, in some alter
the option to filter which connection/variable/config is searched in the secret backend. Please look at the
documentation of the secret backend you are using to see if such option is available.
+On the other hand, if a workers secrets backend is defined, the order of lookup has higher priority for the workers secrets
+backend and than the secrets backend.
Review Comment:
```suggestion
On the other hand, if a workers secrets backend is defined, the order of lookup has higher priority for the workers secrets
backend and then the secrets backend.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating docs to reflect latest state of project for AF3 [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #49280:
URL: https://github.com/apache/airflow/pull/49280#discussion_r2044112997
##########
airflow-core/docs/core-concepts/sensors.rst:
##########
@@ -27,6 +27,6 @@ Because they are primarily idle, Sensors have two different modes of running so
The ``poke`` and ``reschedule`` modes can be configured directly when you instantiate the sensor; generally, the trade-off between them is latency. Something that is checking every second should be in ``poke`` mode, while something that is checking every minute should be in ``reschedule`` mode.
-Much like Operators, Airflow has a large set of pre-built Sensors you can use, both in core Airflow as well as via our *providers* system.
+Much like Operators, Airflow has a large set of pre-built Sensors(housed in the standard provider) you can use, both in core Airflow(present in standard provider) as well as via our *providers* system.
Review Comment:
I think its pretty clear now. I mention in brackets where it stays. Lets see what other reviewers have to say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org