[GitHub] [spark] MaxGekk commented on a change in pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #28328:
URL: https://github.com/apache/spark/pull/28328#discussion_r414566719



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -519,7 +519,9 @@ case class InSet(child: Expression, hset: Set[Any]) extends UnaryExpression with
 
   override def sql: String = {
     val valueSQL = child.sql
-    val listSQL = hset.toSeq.map(Literal(_).sql).mkString(", ")

Review comment:
       It doesn't accept UTF8String at https://github.com/apache/spark/blob/ff39c9271ca04951b045c5d9fca2128a82d50b46/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala#L292




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org