You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/02/01 13:09:54 UTC

[PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

jorisvandenbossche opened a new pull request, #39881:
URL: https://github.com/apache/arrow/pull/39881

   See upstream pin being added (https://github.com/dask/dask/pull/10868 / https://github.com/dask/dask/issues/10869), we are seeing the same failures


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39881:
URL: https://github.com/apache/arrow/pull/39881#discussion_r1474487393


##########
ci/scripts/install_dask.sh:
##########
@@ -35,4 +35,4 @@ else
 fi
 
 # additional dependencies needed for dask's s3 tests
-pip install moto[server] flask requests
+pip install "moto[server]<5" flask requests

Review Comment:
   Should we add a reference to the original issue?
   ```suggestion
   # Moto 5 results in timeouts in s3 tests: https://github.com/dask/dask/issues/10869
   pip install "moto[server]<5" flask requests
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #39881:
URL: https://github.com/apache/arrow/pull/39881#discussion_r1474489618


##########
ci/scripts/install_dask.sh:
##########
@@ -35,4 +35,4 @@ else
 fi
 
 # additional dependencies needed for dask's s3 tests
-pip install moto[server] flask requests
+pip install "moto[server]<5" flask requests

Review Comment:
   Yes, good idea, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39881:
URL: https://github.com/apache/arrow/pull/39881#issuecomment-1921292315

   :warning: GitHub issue #39880 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #39881:
URL: https://github.com/apache/arrow/pull/39881#issuecomment-1921292568

   @github-actions crossbow submit test-conda-python-3.11-dask-latest test-conda-python-3.11-dask-upstream_devel


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #39881:
URL: https://github.com/apache/arrow/pull/39881


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39881:
URL: https://github.com/apache/arrow/pull/39881#issuecomment-1922740241

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4ceb66101382d74c6ef73ff546fad10183ab58d8.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/21138145604) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-39880: [Python][CI] Pin moto<5 for dask integration tests [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39881:
URL: https://github.com/apache/arrow/pull/39881#issuecomment-1921297010

   Revision: f11ffd24e87c8d45c92a74ff7f8ad0efba43fffe
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-925437bf47](https://github.com/ursacomputing/crossbow/branches/all?query=actions-925437bf47)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.11-dask-latest|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-925437bf47-github-test-conda-python-3.11-dask-latest)](https://github.com/ursacomputing/crossbow/actions/runs/7741802565/job/21109519171)|
   |test-conda-python-3.11-dask-upstream_devel|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-925437bf47-github-test-conda-python-3.11-dask-upstream_devel)](https://github.com/ursacomputing/crossbow/actions/runs/7741802562/job/21109519169)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org