svn commit: r810536 - /xerces/java/trunk/src/org/apache/xerces/impl/xs/XMLSchemaLoader.java

[sa...@apache.org]

Author: sandygao
Date: Wed Sep  2 14:57:41 2009
New Revision: 810536

URL: http://svn.apache.org/viewvc?rev=810536&view=rev
Log:
It turned out that even when psvi is off and there is no grammar pool, the schema can still be exposed, making it unsafe to reuse objects in the declaration pool. Disabling the decl pool for now until we are clear about when it can be safely used. (It never worked anyway.)

Modified:
    xerces/java/trunk/src/org/apache/xerces/impl/xs/XMLSchemaLoader.java

Modified: xerces/java/trunk/src/org/apache/xerces/impl/xs/XMLSchemaLoader.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/impl/xs/XMLSchemaLoader.java?rev=810536&r1=810535&r2=810536&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/impl/xs/XMLSchemaLoader.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/impl/xs/XMLSchemaLoader.java Wed Sep  2 14:57:41 2009
@@ -1025,7 +1025,11 @@
         
         // Only use the decl pool when there is no chance that the schema
         // components will be exposed or cached.
-        if (!psvi && fGrammarPool == null) {
+        // TODO: when someone calls loadGrammar(XMLInputSource), the schema is
+        // always exposed even without the use of a grammar pool.
+        // Disabling the "decl pool" feature for now until we understand when
+        // it can be safely used.
+        if (!psvi && fGrammarPool == null && false) {
             if (fDeclPool != null) {
                 fDeclPool.reset();
             }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org