[GitHub] [incubator-superset] ktmud commented on a change in pull request #11253: build: update webpack for npm linking plugins

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #11253:
URL: https://github.com/apache/incubator-superset/pull/11253#discussion_r504294431



##########
File path: superset-frontend/tsconfig.json
##########
@@ -23,12 +23,13 @@
     "target": "esnext"
   },
   "include": [
-    "./src/**/*",
-    "./spec/**/*",
+    "./src/**",
+    "./spec/**",
     // include the source code of each plugin
-    "./node_modules/*superset-ui*/**/src/**/*",
-    "./node_modules/*superset-ui*/**/types/**/*",
+    "./node_modules/*superset-ui*/**/src/**",
+    "./node_modules/*superset-ui*/**/types/**",
     // and the type defs of their dependencies
     "./node_modules/*superset-ui*/**/node_modules/**/*.d.ts"
-  ]
+  ],
+  "exclude": ["./node_modules/*superset-ui*/**/node_modules/@superset-ui/**"]

Review comment:
       Not sure whether this will help but it definitely looks more reasonable than current setup.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org