[GitHub] [carbondata] marchpure commented on a change in pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

[GitBox <gi...@apache.org>]

marchpure commented on a change in pull request #3978:
URL: https://github.com/apache/carbondata/pull/3978#discussion_r503242850



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
##########
@@ -235,14 +237,38 @@ private[sql] case class CarbonProjectForUpdateCommand(
         }
         sys.error("Update operation failed. please check logs.")
     } finally {
-      if (null != dataSet && isPersistEnabled) {
-        dataSet.unpersist()
+      if (updateLock.unlock()) {
+        LOGGER.info(s"updateLock unlocked successfully after update operation $tableName")
+      } else {
+        LOGGER.error(s"Unable to unlock updateLock for table $tableName after table updation");

Review comment:
       I have modified code according to your suggestion




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org