Re: [PR] style(databases-upload-form): update Upload Form cosmetics [superset]

["mistercrunch (via GitHub)" <gi...@apache.org>]

mistercrunch commented on code in PR #30758:
URL: https://github.com/apache/superset/pull/30758#discussion_r1823306214


##########
superset-frontend/src/features/databases/UploadDataModel/index.tsx:
##########
@@ -173,6 +173,12 @@ const allowedExtensionsToAccept = {
   columnar: '.parquet, .zip',
 };
 
+const extensionsToLabel: Record<UploadType, string> = {
+  csv: 'CSV',

Review Comment:
   did a double take on whether this needs to be wrapped with a18n, but i think it's right to NOT make these labels translatable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org