You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/19 22:19:59 UTC
[GitHub] [airflow] pankajastro opened a new pull request, #25844: Fix AzureBatchOperator false positive status
pankajastro opened a new pull request, #25844:
URL: https://github.com/apache/airflow/pull/25844
closes: https://github.com/apache/airflow/issues/25635
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nicholashendrickx-tomtom commented on pull request #25844: Fix AzureBatchOperator false negative status
Posted by GitBox <gi...@apache.org>.
nicholashendrickx-tomtom commented on PR #25844:
URL: https://github.com/apache/airflow/pull/25844#issuecomment-1280904892
Any idea how I can more easily test this? Which configuration did you use to test it @pankajastro?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pankajastro commented on pull request #25844: Fix AzureBatchOperator false negative status
Posted by GitBox <gi...@apache.org>.
pankajastro commented on PR #25844:
URL: https://github.com/apache/airflow/pull/25844#issuecomment-1274093309
> @pankajastro I still have issues with the exit code. I'm passing the following command line to `AzureBatchOperator`:
>
> ```shell
> "/bin/bash -c 'exit 1'"
> ```
>
> And even though the batch job fails on Azure, Airflow still considers the task to be exiting with code 0. We are using `apache-airflow-providers-microsoft-azure@4.3.0`
that's weird, can you please share your airflow `AzureBatchOperator` task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25844: Fix AzureBatchOperator false negative status
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25844:
URL: https://github.com/apache/airflow/pull/25844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nicholashendrickx-tomtom commented on pull request #25844: Fix AzureBatchOperator false negative status
Posted by GitBox <gi...@apache.org>.
nicholashendrickx-tomtom commented on PR #25844:
URL: https://github.com/apache/airflow/pull/25844#issuecomment-1274130068
> that's weird, can you please share your airflow `AzureBatchOperator` task?
```python
cmd_line = "/bin/bash -c 'exit 1'"
batch_operator = AzureBatchOperator(
task_id='batch_operator_with_inline_exit_1',
batch_pool_id='batch_pool_test',
batch_pool_vm_size='STANDARD_F48S_V2',
batch_job_id='batch_job_test',
batch_task_command_line=cmd_line,
batch_task_id='batch_task_test',
batch_max_retries=1,
batch_task_resource_files=resource_files, # var defined elsewhere, irrelevant in this example
batch_task_user_identity=user_identity, # var defined elsewhere
target_dedicated_nodes=1,
azure_batch_conn_id='azure_batch_default',
vm_publisher='Canonical',
vm_offer='0001-com-ubuntu-server-focal',
vm_sku='20_04-lts-gen2',
vm_node_agent_sku_id='batch.node.ubuntu 20.04',
timeout=360,
should_delete_job=False,
should_delete_pool=False
)
```
As said the Azure Portal shows me that the batch job failed, and exited with exit code 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nicholashendrickx-tomtom commented on pull request #25844: Fix AzureBatchOperator false negative status
Posted by GitBox <gi...@apache.org>.
nicholashendrickx-tomtom commented on PR #25844:
URL: https://github.com/apache/airflow/pull/25844#issuecomment-1287176006
I've pushed changed in https://github.com/apache/airflow/pull/27185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nicholashendrickx-tomtom commented on pull request #25844: Fix AzureBatchOperator false negative status
Posted by GitBox <gi...@apache.org>.
nicholashendrickx-tomtom commented on PR #25844:
URL: https://github.com/apache/airflow/pull/25844#issuecomment-1273051639
@pankajastro I still have issues with the exit code. I'm passing the following command line to `AzureBatchOperator`:
```bash
"/bin/bash -c 'exit 1'"
```
And even though the batch job fails on Azure, Airflow still considers the task to be exiting with code 0.
We are using `apache-airflow-providers-microsoft-azure@4.3.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org