You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/28 14:19:41 UTC

[GitHub] jmcarp commented on a change in pull request #4792: [AIRFLOW-3659] Create Google Cloud Transfer Service Operators

jmcarp commented on a change in pull request #4792:  [AIRFLOW-3659] Create Google Cloud Transfer Service Operators 
URL: https://github.com/apache/airflow/pull/4792#discussion_r261214193
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_api_base_hook.py
 ##########
 @@ -188,6 +190,21 @@ def inner_wrapper(self, *args, **kwargs):
 
     fallback_to_default_project_id = staticmethod(fallback_to_default_project_id)
 
+    @staticmethod
+    def catch_http_exception(func):
 
 Review comment:
   What's the benefit of wrapping `HttpError` in `AirflowException`? I think users will understand that an `HttpError` means that a request failed 😄.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services