You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/04/06 20:02:44 UTC
Review Request 45825: AMBARI-15136 Alert definitions: Percentage
params are shown incrrectly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45825/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Eugene Chekanskiy, Jaimin Jetly, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15136
https://issues.apache.org/jira/browse/AMBARI-15136
Repository: ambari
Description
-------
Percentage params need to be shown as whatever sent from BE.
Diffs
-----
ambari-web/app/controllers/main/alerts/definition_configs_controller.js 0141c11
ambari-web/app/models/alerts/alert_config.js 66ff2fb
ambari-web/test/models/alerts/alert_config_test.js 56f1577
Diff: https://reviews.apache.org/r/45825/diff/
Testing
-------
Modified unit tests.
Local ambari-web test passed.
25634 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 45825: AMBARI-15136 Alert definitions: Percentage
params are shown incrrectly
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45825/#review127393
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On April 6, 2016, 6:02 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45825/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 6:02 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Eugene Chekanskiy, Jaimin Jetly, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15136
> https://issues.apache.org/jira/browse/AMBARI-15136
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Percentage params need to be shown as whatever sent from BE.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/alerts/definition_configs_controller.js 0141c11
> ambari-web/app/models/alerts/alert_config.js 66ff2fb
> ambari-web/test/models/alerts/alert_config_test.js 56f1577
>
> Diff: https://reviews.apache.org/r/45825/diff/
>
>
> Testing
> -------
>
> Modified unit tests.
> Local ambari-web test passed.
> 25634 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>