[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8006: Bump commons-io from 2.5 to 2.6

[GitBox <gi...@apache.org>]

asdf2014 commented on a change in pull request #8006: Bump commons-io from 2.5 to 2.6
URL: https://github.com/apache/incubator-druid/pull/8006#discussion_r306146670
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/data/input/impl/FileIteratingFirehose.java
 ##########
 @@ -98,7 +98,7 @@ public InputRowPlusRaw nextRowWithRaw()
     }
   }
 
-  private LineIterator getNextLineIterator()
+  private LineIterator getNextLineIterator() throws IOException
 
 Review comment:
   Since the new version of `LineIterator` supports `try-with-resources`, we should simplify `Closeable ignore2 = lineIterator != null ? lineIterator::close : null` to `Closeable ignore2 = lineIterator` on line #122.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org