You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:02:48 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #1557: [Enhancement] Method passes a concatenated string to SLF4J's or Log4j2's format string [KafkaConsumerRunner]
Alonexc opened a new issue, #1557:
URL: https://github.com/apache/incubator-eventmesh/issues/1557
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at: org/apache/eventmesh/connector/kafka/consumer/KafkaConsumerRunner.java line 95
explanation: This method uses an SLF4J or Log4j2 logger to log a string, where the first (format) string is created using concatenation. You should use {} markers to inject dynamic content into the string, so that String building is delayed until the actual log string is needed. If the log level is high enough that this log statement isn't used, then the appends will never be executed.
### Describe the solution you'd like
Use the {} tag to inject dynamic content into a string.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen closed issue #1557: [Enhancement] Method passes a concatenated string to SLF4J's or Log4j2's format string [KafkaConsumerRunner]
Posted by GitBox <gi...@apache.org>.
qqeasonchen closed issue #1557: [Enhancement] Method passes a concatenated string to SLF4J's or Log4j2's format string [KafkaConsumerRunner]
URL: https://github.com/apache/incubator-eventmesh/issues/1557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Shrikumar18 commented on issue #1557: [Enhancement] Method passes a concatenated string to SLF4J's or Log4j2's format string [KafkaConsumerRunner]
Posted by GitBox <gi...@apache.org>.
Shrikumar18 commented on issue #1557:
URL: https://github.com/apache/incubator-eventmesh/issues/1557#issuecomment-1279394870
Hi @xwm1992 I'd like to work on this, can you please assign this to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org