[GitHub] [incubator-shardingsphere] avalon566 commented on issue #1954: in dev branch, not support "limit ?, ?"

[GitBox <gi...@apache.org>]

avalon566 commented on issue #1954: in dev branch,not support "limit ?,?"
URL: https://github.com/apache/incubator-shardingsphere/issues/1954#issuecomment-469159360
 
 
   Test SQL:select * from t_order limit 10,10
   ```
   java.lang.NumberFormatException: For input string: "10,10"
   	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
   	at java.lang.Integer.parseInt(Integer.java:580)
   	at java.math.BigInteger.<init>(BigInteger.java:470)
   	at org.apache.shardingsphere.core.util.NumberUtil.getExactlyNumber(NumberUtil.java:72)
   	at org.apache.shardingsphere.core.parsing.antlr.extractor.impl.dql.LimitExtractor.createLimitValueSegment(LimitExtractor.java:69)
   	at org.apache.shardingsphere.core.parsing.antlr.extractor.impl.dql.LimitExtractor.extract(LimitExtractor.java:49)
   	at org.apache.shardingsphere.core.parsing.antlr.extractor.SQLSegmentsExtractorEngine.extract(SQLSegmentsExtractorEngine.java:44)
   	at org.apache.shardingsphere.core.parsing.antlr.AntlrParsingEngine.parse(AntlrParsingEngine.java:60)
   	at org.apache.shardingsphere.core.parsing.SQLParsingEngine.parse(SQLParsingEngine.java:68)
   	at org.apache.shardingsphere.core.routing.router.sharding.ParsingSQLRouter.parse(ParsingSQLRouter.java:82)
   	at org.apache.shardingsphere.core.routing.StatementRoutingEngine.route(StatementRoutingEngine.java:54)
   	at org.apache.shardingsphere.shardingproxy.backend.communication.jdbc.wrapper.StatementExecutorWrapper.doShardingRoute(StatementExecutorWrapper.java:72)
   	at org.apache.shardingsphere.shardingproxy.backend.communication.jdbc.wrapper.StatementExecutorWrapper.route(StatementExecutorWrapper.java:55)
   	at org.apache.shardingsphere.shardingproxy.backend.communication.jdbc.JDBCDatabaseCommunicationEngine.execute(JDBCDatabaseCommunicationEngine.java:78)
   	at org.apache.shardingsphere.shardingproxy.backend.text.query.QueryBackendHandler.execute(QueryBackendHandler.java:54)
   	at org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.text.query.MySQLComQueryPacket.execute(MySQLComQueryPacket.java:90)
   	at org.apache.shardingsphere.shardingproxy.frontend.mysql.MySQLFrontendEngine.writePackets(MySQLFrontendEngine.java:119)
   	at org.apache.shardingsphere.shardingproxy.frontend.mysql.MySQLFrontendEngine.executeCommand(MySQLFrontendEngine.java:104)
   	at org.apache.shardingsphere.shardingproxy.frontend.common.netty.FrontendChannelInboundHandler$1.run(FrontendChannelInboundHandler.java:70)
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   	at java.lang.Thread.run(Thread.java:748)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services