You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 15:19:00 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #7179: ARROW-8732: [C++] Add basic cancellation API

lidavidm commented on a change in pull request #7179:
URL: https://github.com/apache/arrow/pull/7179#discussion_r542465782



##########
File path: cpp/src/arrow/util/thread_pool.h
##########
@@ -218,7 +220,8 @@ class ARROW_EXPORT ThreadPool : public Executor {
 
   ThreadPool();
 
-  Status SpawnReal(TaskHints hints, std::function<void()> task) override;
+  Status SpawnReal(TaskHints hints, std::function<void()> task,
+                   StopToken* = NULLPTR) override;

Review comment:
       Thanks for the heads up. This looks good, we don't yet use the Executor interface but will move to it once we start looking at upstreaming/open-sourcing our project.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org