You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/01/27 21:06:52 UTC

[GitHub] [zookeeper] ctubbsii commented on pull request #1802: ZOOKEEPER-4455: Move to https://reload4j.qos.ch/ (remove log4j1)

ctubbsii commented on pull request #1802:
URL: https://github.com/apache/zookeeper/pull/1802#issuecomment-1023638912


   @anmolnar wrote:
   > @eolivelli Waiting for the syntax fix to make CI happy again. This patch could render the logback migration pointless to be honest.
   
   If there was interest in staying on log4j1 longer, it does obviate the *need* to move to logback. However, you had some other good changes in that migration that improved using logs for tests, and the changes you did to move to logback increase the confidence that users can swap out the implementation at runtime with any other slf4j runtime implementation jar. I think migrating to reload4j is a temporary hack. Long-term, what you did to get onto logback will be more useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org