You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/03/06 16:48:24 UTC
[GitHub] [hadoop] elek commented on a change in pull request #549:
HDDS-1213. Support plain text S3 MPU initialization request
elek commented on a change in pull request #549: HDDS-1213. Support plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#discussion_r263033449
##########
File path: hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
##########
@@ -74,17 +70,16 @@ Test Multipart Upload Complete
Should contain ${result} UploadId
#upload parts
- ${system} = Evaluate platform.system() platform
- Run Keyword if '${system}' == 'Darwin' Create Random file for mac
- Run Keyword if '${system}' == 'Linux' Create Random file for linux
- ${result} = Execute AWSS3APICli upload-part --bucket ${BUCKET} --key multipartKey1 --part-number 1 --body /tmp/part1 --upload-id ${uploadID}
- ${eTag1} = Execute and checkrc echo '${result}' | jq -r '.ETag' 0
- Should contain ${result} ETag
+ ${system} = Evaluate platform.system() platform
+ Run Keyword Create Random file 5
+ ${result} = Execute AWSS3APICli upload-part --bucket ${BUCKET} --key multipartKey1 --part-number 1 --body /tmp/part1 --upload-id ${uploadID}
+ ${eTag1} = Execute and checkrc echo '${result}' | jq -r '.ETag' 0
+ Should contain ${result} ETag
Execute echo "Part2" > /tmp/part2
- ${result} = Execute AWSS3APICli upload-part --bucket ${BUCKET} --key multipartKey1 --part-number 2 --body /tmp/part2 --upload-id ${uploadID}
- ${eTag2} = Execute and checkrc echo '${result}' | jq -r '.ETag' 0
- Should contain ${result} ETag
+ ${result} = Execute AWSS3APICli upload-part --bucket ${BUCKET} --key multipartKey1 --part-number 2 --body /tmp/part2 --upload-id ${uploadID}
+ ${eTag2} = Execute and checkrc echo '${result}' | jq -r '.ETag' 0
+ Should contain ${result} ETag
Review comment:
Yetus asked me to not use tab. Without fixing the tabs the patch would cause a whitespace mismatch (my new lines with spaces and the old lines with tabs). So it's intentional, but I can move to a different
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org