You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/12/15 17:18:00 UTC
[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key
Jean-Daniel Cryans has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5521
Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key
......................................................................
KUDU-1775 (fixup): fix error message for too-large encoded key
The previous patch in this series had a typo in the error message,
causing it to report the value for max cell size instead of max encoded
key.
Change-Id: I5fd5369910a888ac481f9fdeda7f0543ca38ec6d
Reviewed-on: http://gerrit.cloudera.org:8080/5515
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 2ed179a7a188b4748a43a829940764ab5dddbc1c)
---
M src/kudu/client/client-test.cc
M src/kudu/tablet/tablet.cc
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/5521/1
--
To view, visit http://gerrit.cloudera.org:8080/5521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fd5369910a888ac481f9fdeda7f0543ca38ec6d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key
......................................................................
KUDU-1775 (fixup): fix error message for too-large encoded key
The previous patch in this series had a typo in the error message,
causing it to report the value for max cell size instead of max encoded
key.
Change-Id: I5fd5369910a888ac481f9fdeda7f0543ca38ec6d
Reviewed-on: http://gerrit.cloudera.org:8080/5515
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 2ed179a7a188b4748a43a829940764ab5dddbc1c)
Reviewed-on: http://gerrit.cloudera.org:8080/5521
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/client/client-test.cc
M src/kudu/tablet/tablet.cc
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fd5369910a888ac481f9fdeda7f0543ca38ec6d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key
......................................................................
Patch Set 1:
Pulling this patch in since it fixes the previous patch in this branch.
--
To view, visit http://gerrit.cloudera.org:8080/5521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd5369910a888ac481f9fdeda7f0543ca38ec6d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd5369910a888ac481f9fdeda7f0543ca38ec6d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No