[GitHub] [geode] pivotal-jbarrett commented on issue #4075: GEODE-6964: Move geode log4j core classes to geode-log4j

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

> > I think these are left over from issues with "old-versions" from a really old version of the Gradle files. I think they could be cleaned up now but nobody has taken the time to look into it.
> 
> I'm talking about new excludes that are added by this commit. For example, this change in geode-dunit. Maybe this is just copying a bad pattern in our gradle files?

I think you're right that it's a copy of a previous pattern. I am pretty sure it is safe to cleanup now. There is some danger in the rolling upgrade tests. I would suggest a separate PR to just clean up the dependency mess. There are other things like this we could clean up. Also converting to Java Library plugin all over should clean up some messes.

[ Full content available at: https://github.com/apache/geode/pull/4075 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org