You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/11/16 23:22:01 UTC
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11948
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
---
M docs/topics/impala_adls.xml
1 file changed, 40 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/11948/1
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/153/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 23:32:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/154/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 23:58:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11948/1/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:
http://gerrit.cloudera.org:8080/#/c/11948/1/docs/topics/impala_adls.xml@283
PS1, Line 283: <codeblock>abfs://<varname>container</varname>@<varname>account</varname>.dfs.core.windows.net/<varname>path</varname>/<varname>file</varname></codeblock><p>or</p><codeblock>abfss://<varname>container</varname>@<varname>account</varname>.dfs.core.windows.net/<varname>path</varname>/<varname>file</varname></codeblock>
I realize this is the output of a tool, but if we can break up this long line, I would appreciate it.
http://gerrit.cloudera.org:8080/#/c/11948/1/docs/topics/impala_adls.xml@298
PS1, Line 298: abfss://
"abfs://"
You have abfss:// twice.
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 23:29:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/153/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 23:22:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
Patch Set 2: Code-Review+2
Thanks, looks good.
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 23:45:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/154/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 23:40:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Reviewed-on: http://gerrit.cloudera.org:8080/11948
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_adls.xml
1 file changed, 43 insertions(+), 23 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 )
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11948/1/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:
http://gerrit.cloudera.org:8080/#/c/11948/1/docs/topics/impala_adls.xml@283
PS1, Line 283: <codeblock>abfs://<varname>container</varname>@<varname>account</varname>.dfs.core.windows.net/<varname>path</varname>/<varname>file</varname></codeblock><p>or</p><codeblock>abfss://<varname>container</varname>@<varname>account</varname>.dfs.core.windows.net/<varname>path</varname>/<varname>file</varname></codeblock>
> I realize this is the output of a tool, but if we can break up this long li
Fixed. Still look very long in XML, but the output HTML looks fine.
http://gerrit.cloudera.org:8080/#/c/11948/1/docs/topics/impala_adls.xml@298
PS1, Line 298: abfss://
> "abfs://"
Done
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 23:41:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello mackrorysd@apache.org, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11948
to look at the new patch set (#2).
Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
......................................................................
IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme
Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
---
M docs/topics/impala_adls.xml
1 file changed, 43 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/11948/2
--
To view, visit http://gerrit.cloudera.org:8080/11948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88f615cf23f406035e544e68adacdd0393f69ab3
Gerrit-Change-Number: 11948
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ma...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>