[GitHub] [spark] sunchao edited a comment on pull request #32354: [SPARK-35232][SQL] Nested column pruning should retain column metadata

[GitBox <gi...@apache.org>]

sunchao edited a comment on pull request #32354:
URL: https://github.com/apache/spark/pull/32354#issuecomment-827151576


   @viirya without the change in `InMemoryTable` the test will not fail. This is because `InMemoryTable` doesn't have column pruning at the moment and it just return the table schema (which has the metadata) as the read schema in `InMemoryBatchScan`, but a more realistic data source would use the `requestedSchema` (e.g., [Iceberg](https://github.com/apache/iceberg/blob/master/spark3/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java#L132)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org