You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/19 05:48:50 UTC
[GitHub] [arrow-experimental-rs-parquet2] jorgecarleitao opened a new pull request #1: Adds
jorgecarleitao opened a new pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1
This PR is pending clearance.
It contains the source code of parquet2 rebased on top of all commits in arrow-rs, so that history of arrow-rs is preserved.
Todos:
[ ] add headers
[ ] add RAT check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] jorgecarleitao commented on pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#issuecomment-873635928
@elferherrera @jhorstmann , for Apache's IP clearance:
* would it be ok for your contributions to parquet2 to be donated to Apache under the CLA?
* if yes, could you sign and submit a CLA, so that we have the paperwork in order for this to proceed?
Sorry for the inconvenience, this does not seem to be needed in normal contributions, but for some reason for these clearances it is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] jorgecarleitao commented on pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#issuecomment-880369806
@jhorstmann , did you submitted a CLA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] Jimexist commented on a change in pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#discussion_r660490289
##########
File path: .github/workflows/test.yml
##########
@@ -0,0 +1,119 @@
+name: Check and test
+
+on: [push, pull_request]
+
+jobs:
+ # test the crate
+ linux-test:
+ name: Test
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Cache Cargo
+ uses: actions/cache@v2
+ with:
+ path: /github/home/.cargo
+ # these represent dependencies downloaded by cargo
+ # and thus do not depend on the OS, arch nor rust version.
+ key: cargo-cache-
+ - name: Cache dependencies
+ uses: actions/cache@v2
+ with:
+ path: /github/home/target
+ # these represent compiled steps of both dependencies and arrow
+ # and thus are specific for a particular OS, arch and rust version.
+ key: ${{ runner.os }}-amd64-target-cache-stable
+ - name: Setup parquet files
+ run: |
+ apt update && apt install python3-pip python3-venv -y -q
+ python3 -m venv venv
+ venv/bin/pip install pip --upgrade
+ venv/bin/pip install pyarrow==3
Review comment:
use 4.0.1? https://pypi.org/project/pyarrow/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] jhorstmann commented on pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#issuecomment-873943202
I'm of course ok with the donation, will check the CLA requirements later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] codecov-commenter commented on pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#issuecomment-865506932
# [Codecov](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@5518118`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 4dffc8d differs from pull request most recent head 9e7ca73. Consider uploading reports for the commit 9e7ca73 to get more accurate results
[](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 75.83%
=========================================
Files ? 62
Lines ? 3174
Branches ? 0
=========================================
Hits ? 2407
Misses ? 767
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5518118...9e7ca73](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] codecov-commenter commented on pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#issuecomment-865506932
# [Codecov](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@5518118`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 4dffc8d differs from pull request most recent head 9e7ca73. Consider uploading reports for the commit 9e7ca73 to get more accurate results
[](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 75.83%
=========================================
Files ? 62
Lines ? 3174
Branches ? 0
=========================================
Hits ? 2407
Misses ? 767
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5518118...9e7ca73](https://codecov.io/gh/apache/arrow-experimental-rs-parquet2/pull/1?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] jhorstmann commented on pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#issuecomment-873943202
I'm of course ok with the donation, will check the CLA requirements later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-experimental-rs-parquet2] Jimexist commented on a change in pull request #1: Adds parquet2
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #1:
URL: https://github.com/apache/arrow-experimental-rs-parquet2/pull/1#discussion_r660490289
##########
File path: .github/workflows/test.yml
##########
@@ -0,0 +1,119 @@
+name: Check and test
+
+on: [push, pull_request]
+
+jobs:
+ # test the crate
+ linux-test:
+ name: Test
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Cache Cargo
+ uses: actions/cache@v2
+ with:
+ path: /github/home/.cargo
+ # these represent dependencies downloaded by cargo
+ # and thus do not depend on the OS, arch nor rust version.
+ key: cargo-cache-
+ - name: Cache dependencies
+ uses: actions/cache@v2
+ with:
+ path: /github/home/target
+ # these represent compiled steps of both dependencies and arrow
+ # and thus are specific for a particular OS, arch and rust version.
+ key: ${{ runner.os }}-amd64-target-cache-stable
+ - name: Setup parquet files
+ run: |
+ apt update && apt install python3-pip python3-venv -y -q
+ python3 -m venv venv
+ venv/bin/pip install pip --upgrade
+ venv/bin/pip install pyarrow==3
Review comment:
use 4.0.1? https://pypi.org/project/pyarrow/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org