[GitHub] [incubator-mxnet] hankaj commented on a diff in pull request #21136: Python string formatting

[GitBox <gi...@apache.org>]

hankaj commented on code in PR #21136:
URL: https://github.com/apache/incubator-mxnet/pull/21136#discussion_r968317987


##########
tests/nightly/model_backwards_compatibility_check/common.py:
##########
@@ -105,10 +105,10 @@ def get_top_level_folders_in_bucket(s3client, bucket_name):
     result = bucket.meta.client.list_objects(Bucket=bucket.name, Delimiter=backslash)
     folder_list = list()
     if 'CommonPrefixes' not in result:
-        logging.error('No trained models found in S3 bucket : %s for this file. '
-                      'Please train the models and run inference again' % bucket_name)
-        raise Exception("No trained models found in S3 bucket : %s for this file. "
-                        "Please train the models and run inference again" % bucket_name)
+        logging.error('No trained models found in S3 bucket : {} for this file. '

Review Comment:
   In CI I got the error that you should not use f-strings in messages of logging functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org