You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Yoritaka Sakakura (JIRA)" <ta...@jakarta.apache.org> on 2005/11/22 05:04:43 UTC
[jira] Created: (TAPESTRY-770) client:page scope appends unnecessary state when generating link (using friendly urls)
client:page scope appends unnecessary state when generating link (using friendly urls)
--------------------------------------------------------------------------------------
Key: TAPESTRY-770
URL: http://issues.apache.org/jira/browse/TAPESTRY-770
Project: Tapestry
Type: Bug
Components: Framework
Versions: 4.0
Environment: 4.0-b12
Reporter: Yoritaka Sakakura
Priority: Minor
PageClientPropertyPersistenceScope.shouldEncodeState checks property page against current page rather than a link's target page when invoked via LinkFactory.constructLink
LinkFactoryImpl has already called ServiceEncoder.encode before passing the ServiceEncoding to PropertyPersistenceStrategySource, so the ServiceConstants.PAGE parameter value (seems like easiest check) has been moved into the servlet path and nulled out. Would it be possible to:
* add the persistent properties (and ServiceEncoderImpl.resetModified) before ServiceEncode processing in LinkFactoryImpl
* check the encoding's page parameter rather before active page in PageClientPropertyPersistenceScope
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Resolved: (TAPESTRY-770) client:page scope appends unnecessary state when generating link (using friendly urls)
Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-770?page=all ]
Howard M. Lewis Ship resolved TAPESTRY-770:
-------------------------------------------
Resolution: Invalid
Assign To: Howard M. Lewis Ship
Page A may generate a link to page B, and yet page A's state is encoded into the URL. You see this as an error. From Tapestry's point of view, the state should not be discarded until page B is succesfully acitvated; page B may redirect back to page A from pageValidate() and we'll still want that state. This ensures proper behavior, at the risk of a few extra-long URLs.
> client:page scope appends unnecessary state when generating link (using friendly urls)
> --------------------------------------------------------------------------------------
>
> Key: TAPESTRY-770
> URL: http://issues.apache.org/jira/browse/TAPESTRY-770
> Project: Tapestry
> Type: Bug
> Components: Framework
> Versions: 4.0
> Environment: 4.0-b12
> Reporter: Yoritaka Sakakura
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> PageClientPropertyPersistenceScope.shouldEncodeState checks property page against current page rather than a link's target page when invoked via LinkFactory.constructLink
> LinkFactoryImpl has already called ServiceEncoder.encode before passing the ServiceEncoding to PropertyPersistenceStrategySource, so the ServiceConstants.PAGE parameter value (seems like easiest check) has been moved into the servlet path and nulled out. Would it be possible to:
> * add the persistent properties (and ServiceEncoderImpl.resetModified) before ServiceEncode processing in LinkFactoryImpl
> * check the encoding's page parameter rather before active page in PageClientPropertyPersistenceScope
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org